Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
osd: initial minimal efforts to clean up PG interface #17708
@liewegas Build failed.
10 or 20 doesn't make much of difference as long as it's there. In case the pgs won't get forced flags, you may need to find out why, whether that was wrongly issued command that missed some pgs (for example, a bug in some script that calls forced recovery) or bad timing that caused pgs in question to change state to one that's invalid for these commands after issuing them.
3 times, most recently
Sep 19, 2017
4 times, most recently
Sep 26, 2017
The net result is that the imported PG will already be up to date when the OSD starts, vs previously where it would have to do a rebuild on startup and there would be some hidden activity slowing osd startup.
(See the last 5 commits or so)
Oct 9, 2017
referenced this pull request
Dec 1, 2017
It makes me very nervous to backport this. Between luminous and this PR a ton of compatibility code for <luminous was ripped out, so I'm worried that there is some dependency (although I guess that will turn on during a backport).
FWIW I was planning on backporting the recovery reservation fixes and it was too painful... maybe this would help, but I'm also okay with not backporting it at all.
I guess give it a go and see how it goes?