Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: cleanup unused option mon_health_data_update_interval #17728

Merged
merged 1 commit into from Oct 2, 2017

Conversation

Projects
None yet
4 participants
@ygtzf
Copy link
Contributor

commented Sep 14, 2017

The config option mon_health_data_update_interval seems to be unused now.

Signed-off-by: Yao Guotao yaoguot@gmail.com

@jecluis

This comment has been minimized.

Copy link
Member

commented Sep 14, 2017

Please change the commit title from unused parameter to unused option.
Other than that, LGTM.

@jecluis
Copy link
Member

left a comment

commit title should be changed from unused parameter to unused option.

@ygtzf ygtzf changed the title mon: cleanup unused parameter mon_health_data_update_interval mon: cleanup unused option mon_health_data_update_interval Sep 14, 2017

mon: cleanup unused option mon_health_data_update_interval
Signed-off-by: Yao Guotao <yaoguot@gmail.com>

@ygtzf ygtzf force-pushed the ygtzf:cleanup-unused-parameter branch from 431f1bf to db9c2af Sep 14, 2017

@ygtzf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2017

@jecluis I modify the commit titile. But, the check for docs is failed, How can do it ? Thanks.

@ygtzf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2017

Jenkins re-test this please (docs check failed due to Error fetching remote repo 'origin')

@ygtzf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

@jecluis OK now

@ygtzf

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2017

@jecluis ping

comment addressed

@tchaikov tchaikov merged commit dd4e4ed into ceph:master Oct 2, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.