New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: os/bluestore: replace 21089 repair with something online (instead of fsck) #17734

Merged
merged 3 commits into from Oct 3, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Sep 14, 2017

The fsck solution requires you to run fsck, which nobody will probably ever
do. Do it on freelist init instead.

liewegas added some commits Sep 14, 2017

os/bluestore/KernelDevice: hack to inject bad device size
This conditionally reintroduces bug http://tracker.ceph.com/issues/21089,
fixed by f6f1ae3, to aid in testing
repair.

Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore: fsck: remove fsck repair for 21089
This requires the user to run fsck, which they likely won't do.

Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore: repair 21089 on freelist init
Fix up the size inconsistency on freelist init.  This way it will always
happen after an upgrade... and before the user moves to something
post-luminous.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas added this to the luminous milestone Sep 14, 2017

@liewegas liewegas requested a review from xiexingguo Sep 14, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Sep 14, 2017

Member

tested with

diff --git a/src/vstart.sh b/src/vstart.sh
index 82ec76bf94..56de2f6cce 100755
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -627,14 +627,14 @@ EOF
             echo "add osd$osd $uuid"
             ceph_adm osd create $uuid
             ceph_adm osd crush add osd.$osd 1.0 host=$HOSTNAME root=default
-            $SUDO $CEPH_BIN/ceph-osd -i $osd $ARGS --mkfs --mkkey --osd-uuid $uuid
+            $SUDO $CEPH_BIN/ceph-osd -i $osd $ARGS --mkfs --mkkey --osd-uuid $uuid --bdev-inject-bad-size
Member

liewegas commented Sep 14, 2017

tested with

diff --git a/src/vstart.sh b/src/vstart.sh
index 82ec76bf94..56de2f6cce 100755
--- a/src/vstart.sh
+++ b/src/vstart.sh
@@ -627,14 +627,14 @@ EOF
             echo "add osd$osd $uuid"
             ceph_adm osd create $uuid
             ceph_adm osd crush add osd.$osd 1.0 host=$HOSTNAME root=default
-            $SUDO $CEPH_BIN/ceph-osd -i $osd $ARGS --mkfs --mkkey --osd-uuid $uuid
+            $SUDO $CEPH_BIN/ceph-osd -i $osd $ARGS --mkfs --mkkey --osd-uuid $uuid --bdev-inject-bad-size

@liewegas liewegas added the bluestore label Sep 14, 2017

@xiexingguo

Super!

@liewegas liewegas merged commit 66af04c into ceph:luminous Oct 3, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-21089-onmount branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment