Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/options: document objecter, filer, and journal options #17740

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Copy link
Member

commented Sep 14, 2017

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from tchaikov Sep 14, 2017

@amitkumar50
Copy link
Contributor

left a comment

Looks Correct Though.


Option("journaler_write_head_interval", Option::TYPE_INT, Option::LEVEL_ADVANCED)
.set_default(15)
.set_description(""),
.set_description("Frequency of journal header updates (to help bound replay time)"),

This comment has been minimized.

Copy link
@tchaikov

tchaikov Sep 19, 2017

Contributor

imho, the unit of frequency is hertz not second. can we s/Frequency/Interval in seconds/ here?

@tchaikov
Copy link
Contributor

left a comment

aside from the nit, lgtm.

common/options: document objecter, filer, and journal options
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-objecter-configs branch from b4159fa to 096aab7 Sep 19, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2017

updated!

@liewegas liewegas added the needs-qa label Sep 19, 2017

@liewegas liewegas merged commit 787ea8a into ceph:master Sep 22, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-objecter-configs branch Sep 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.