Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/NVMEDevice: Remove using dpdk thread #17769

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
5 participants
@optimistyzy
Copy link
Contributor

commented Sep 17, 2017

Do not use DPDK's thread but use the run in complete mode,
thus we do not need to bind two cores for SPDK.

Signed-off-by: Ziye Yang optimistyzy@gmail.com
Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com

@optimistyzy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2017

if (!data_buf_mempool.empty()) {
for (uint16_t i = 0; i < data_buffer_default_num; i++) {
void *b = data_buf_mempool[i];
assert(b);

This comment has been minimized.

Copy link
@amitkumar50

amitkumar50 Sep 18, 2017

Contributor

indentation incorrect

This comment has been minimized.

Copy link
@optimistyzy

optimistyzy Sep 18, 2017

Author Contributor

Updated.

os/bluestore/NVMEDevice: Remove using dpdk thread
Do not use DPDK's thread but use the run in complete mode,
thus we do not need to bind two cores for SPDK.

Signed-off-by: Ziye Yang <optimistyzy@gmail.com>
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>

@optimistyzy optimistyzy force-pushed the optimistyzy:97_new_opt branch from aeec929 to 4485154 Sep 18, 2017

@yuyuyu101
Copy link
Member

left a comment

tested locally

@liewegas liewegas merged commit 20b0055 into ceph:master Sep 28, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.