Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: error out if setting ruleset-* ec profile property #17848

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

commented Sep 20, 2017

We change ruleset -> crush back in dc7a2aa.
If someone tries to use the old property, error out early, instead of
silently not doing the thing they thought they told us to do.

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from markhpc Sep 20, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

commented Sep 21, 2017

retest this please

@liewegas liewegas force-pushed the liewegas:wip-ruleset-errors branch from c581762 to 40cfaaf Sep 23, 2017

mon/OSDMonitor: error out if setting ruleset-* ec profile property
We change ruleset -> crush back in dc7a2aa.
If someone tries to use the old property, error out early, instead of
silently not doing the thing they thought they told us to do.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-ruleset-errors branch from 40cfaaf to 6376d75 Sep 24, 2017

@liewegas liewegas merged commit e0beb1e into ceph:master Sep 25, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-ruleset-errors branch Sep 25, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

commented Sep 25, 2017

backport #17936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.