New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: core: Improve OSD startup time by only scanning for omap corruption once #17889

Merged
merged 5 commits into from Oct 31, 2017

Conversation

Projects
None yet
6 participants
@smithfarm
Contributor

smithfarm commented Sep 21, 2017

@smithfarm smithfarm self-assigned this Sep 21, 2017

@smithfarm smithfarm added this to the luminous milestone Sep 21, 2017

@smithfarm smithfarm added bug fix core tools and removed bug fix labels Sep 21, 2017

@smithfarm smithfarm requested a review from dzafman Sep 21, 2017

@smithfarm smithfarm changed the title from luminous: Add export and remove ceph-objectstore-tool command option to luminous: core: Add export and remove ceph-objectstore-tool command option; improve OSD startup time by only scanning for omap corruption once Sep 21, 2017

@dzafman

This comment has been minimized.

Show comment
Hide comment
@dzafman

dzafman Sep 22, 2017

Member

The first 4 commits are also in #17896. You and @liewegas need to figure out how you want to merge these 2.

Member

dzafman commented Sep 22, 2017

The first 4 commits are also in #17896. You and @liewegas need to figure out how you want to merge these 2.

@dzafman dzafman self-assigned this Sep 22, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Oct 5, 2017

Member

rebase this?

Member

liewegas commented Oct 5, 2017

rebase this?

scienceluo and others added some commits Aug 28, 2017

osd, mds, tools: drop the invalid comment and some unused variables
Signed-off-by: Luo Kexue <luo.kexue@zte.com.cn>
(cherry picked from commit 2e93424)
tools: Add --backend option to ceph-osdomap-tool default to rocksdb
Fix hard-coded "leveldb" backend.  The command is broken in Luminous
now that "rocksdb" is the default.

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit de43493)
tools: Show DB state information
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3214882)
tools: Add the ability to reset state to v2
Available for testing and user downgrade.

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 3e4d686)
osd: Only scan for omap corruption once
Before
 	state 2: Can have complete tables (some may be bad)
	state 3: Never had complete tables
After
 	state 2: Can have complete tables (some may be bad)
	state 3 with legacy: Can have complete tables (bad ones are cleared)
	state 3: Never had complete tables

Once OSDs boot with this change you can't downgrade to a previous release.
If someone does downgrade they could have unstable OSDs that hit assert(state.v < 3).
The following command run after shutting down the cluster but before downgrading
ceph packages would be a way to fix this.

ceph-osdomap-tool --omap-path ... --command resetv2

Fixes: http://tracker.ceph.com/issues/21328

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 8805ef5)
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Oct 5, 2017

Contributor

@liewegas Rebased, thanks.

Contributor

smithfarm commented Oct 5, 2017

@liewegas Rebased, thanks.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Oct 5, 2017

Contributor

jenkins test docs

Contributor

smithfarm commented Oct 5, 2017

jenkins test docs

@dzafman dzafman changed the title from luminous: core: Add export and remove ceph-objectstore-tool command option; improve OSD startup time by only scanning for omap corruption once to luminous: core: Improve OSD startup time by only scanning for omap corruption once Oct 5, 2017

@dzafman

dzafman approved these changes Oct 5, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Oct 5, 2017

Contributor

jenkins test docs

Contributor

smithfarm commented Oct 5, 2017

jenkins test docs

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Oct 20, 2017

Member

jenkins test docs

Member

liewegas commented Oct 20, 2017

jenkins test docs

@theanalyst theanalyst requested review from liewegas and dzafman Oct 27, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-6 and will be merged when approved

Member

theanalyst commented Oct 27, 2017

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-6 and will be merged when approved

@kmroz kmroz merged commit a7f5199 into ceph:luminous Oct 31, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-21372-luminous branch Oct 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment