Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: sort servers and OSDs in OSD list #17993

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Copy link
Contributor

commented Sep 27, 2017

John Spray
mgr/dashboard: sort servers and OSDs in OSD list
Fixes: http://tracker.ceph.com/issues/21572
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp added bug fix mgr labels Sep 27, 2017

@jcsp jcsp requested a review from tchaikov Sep 27, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

tested locally.

@tchaikov tchaikov merged commit af11e5c into ceph:master Sep 28, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
result[hostname].append(summary)

result[hostname].sort(key=lambda a: a['id'])

This comment has been minimized.

Copy link
@liuchang0812

liuchang0812 Sep 28, 2017

Contributor

what's the type of a['id']? we should use sort(key=lambda a: int(a'id']) if it's str.

This comment has been minimized.

Copy link
@tchaikov

tchaikov Sep 28, 2017

Contributor

yeah, see PyModules::dump_server(), will fix.

the "id" in summary has been already converted before calling _osd_summary(), so we are good.

This comment has been minimized.

Copy link
@liuchang0812

liuchang0812 Sep 28, 2017

Contributor

yeah. it's correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.