Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: bring in latest dmclock library updates #17997

Merged
merged 2 commits into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@ivancich
Copy link
Member

commented Sep 27, 2017

Roughly, the changes fall into three categories. Some changes simply deal with code clarity and making sure variables are initialized properly (issues identified via static analysis tools). Some changes add additional changes that can be configured, but do not alter default behavior. One change does alter default behavior, and that seems to achieve better results in the computation of delta and rho for the distributed part of the calculation.

dmclock is incorporated into ceph as a git subtree. This PR was achieved via a git subtree pull.

ivancich added some commits Sep 27, 2017

Squashed 'src/dmclock/' changes from a9e777f08f..93f760c57c
93f760c57c Merge pull request #40 from ivancich/wip-change-client-rec-init
824d92dd3d Merge pull request #38 from ivancich/wip-improve-next-request-return
941d1bef54 Change initialization of IndIntruHeapData to C++'s value-initialization to better future-proof the code. Since at the momeent they are scalars they'll be zero-initialized (i.e., to zero). However if they ever become something more complex, their default constructors will be called.
19153d979f Merge pull request #39 from ivancich/wip-delta-rho-plugin
a94c4e086c Allow the calculations of rho and delta to be handled by a "tracker" specified via template parameter (i.e., by static polymorphism). The tracker follows a simple interface constisting of three functions and one static function.
856a26c466 Clarify code surrounding the return value of do_next_request.
b632cfda4f Merge pull request #37 from ivancich/wip-fix-uninit-data
e6df585153 The coverity scan published in ceph-devel on 2017-09-21 revealed some uninitialized data in a constructor. This fixes that.
165a02542d Merge pull request #34 from TaewoongKim/anticipate
72e4df95cf Make anticipation_timeout configurable with config file
2f06d632d5 Add anticipation duration that keeps from resetting tag values to the current time

git-subtree-dir: src/dmclock
git-subtree-split: 93f760c57c75b9eb88382bcba29fcac3ce365e7f
Merge commit 'b6374d40bcaa4b73d440bb6d8ed42838dec57566' into wip-brin…
…g-in-latest-dmclock

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

@ivancich ivancich added the core label Sep 27, 2017

@ivancich ivancich requested a review from tchaikov Sep 27, 2017

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2017

Note: git subtree pull --squash turns the multiple commits in the library into two commits, the first of which is not signed. This is an issue with the tooling.

@tchaikov tchaikov changed the title [DNM] osd: bring in latest dmclock library updates osd: bring in latest dmclock library updates Sep 28, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

adding DNM label and remove the "[DNM]" prefix in the pull request title.

test::MySim* sim,
test::MySim::ClientFilter client_disp_filter,
int head_w, int data_w, int data_prec) {
test::MySim* sim,

This comment has been minimized.

Copy link
@amitkumar50

amitkumar50 Sep 28, 2017

Contributor

tabs left

This comment has been minimized.

Copy link
@ivancich

ivancich Sep 28, 2017

Author Member

Is there an issue with tabs? Many (most? all?) ceph source files have headers of:

// -- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t --
// vim: ts=8 sw=2 smarttab

which directs text editors such as vim and emacs to use tabs.

@@ -64,15 +158,15 @@ namespace crimson {

Counter delta_counter; // # reqs completed
Counter rho_counter; // # reqs completed via reservation
std::map<S,ServerInfo> server_map;
std::map<S,T> server_map;

This comment has been minimized.

Copy link
@amitkumar50

amitkumar50 Sep 28, 2017

Contributor

tab

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Sep 30, 2017

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2017

@tchaikov Are you able to merge despite the missing "signed off by" in the git subtree pull?

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2017

@ivancich ivancich removed the DNM label Oct 3, 2017

@ivancich

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2017

@tchaikov Fair enough! Thanks.

@tchaikov tchaikov merged commit 0ee5afd into ceph:master Oct 3, 2017

4 of 5 checks passed

Signed-off-by one or more commits in this PR are not signed
Details
Docs: build check OK - docs built
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.