Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume lvm api refactor/move #18110

Merged
merged 8 commits into from Oct 4, 2017

Conversation

Projects
None yet
2 participants
@alfredodeza
Copy link
Contributor

commented Oct 4, 2017

Now that ceph-volume disk is being worked on at the same time that ceph-volume lvm zap is, both need to interact with the LVM API that was in place for the lvm subcommand.

There is a need for that API to be shared across implementations, so it is better to have it in its own, separate module so that others can consume it.

This is just a refactor and does not introduce new functionality, but needed to avoid conflicts for lvm zap and disk work

alfredodeza added some commits Oct 3, 2017

ceph-volume create an api module to hold common api modules
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume move lvm/api.py to api/lvm.py so disk can consume it
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume devices.lvm refactor importing api to come from api/lvm.py
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests refactor lvm api import in conftest
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests refactor lvm api import for activate tests
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests refactor lvm api import for api tests
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests refactor lvm api import for test_listing
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests move lvm api tests into its new test module
Signed-off-by: Alfredo Deza <adeza@redhat.com>

@alfredodeza alfredodeza requested a review from andrewschoen Oct 4, 2017

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

jenkins test ceph-volume centos7-create

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2017

jenkins test ceph-volume xenial-create

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2017

jenkins test ceph-volume centos7-create

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2017

jenkins test ceph-volume xenial-create

@andrewschoen andrewschoen merged commit 7d85e18 into master Oct 4, 2017

8 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume testing centos7-create ceph-volume centos7-create OK
Details
ceph-volume testing xenial-create ceph-volume xenial-create OK
Details
ceph-volume tox testing ceph-volume tox OK
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the wip-volume-api-change branch Apr 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.