New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-disk: retry on OSError #18189

Merged
merged 2 commits into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Oct 9, 2017

tchaikov added some commits Oct 7, 2017

ceph-disk: factor out the retry logic into a decorator
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 02a8620)
ceph-disk: retry on OSError
we are likely to
1) create partition, for instance, sdc1
2) partprobe sdc
3) udevadm settle
4) check the device by its path: /dev/sdc1

but there is chance that the uevent sent from kernel fails to reach udev
before we call "udevadm", hence "/dev/sdc1" does not exist even after
"udevadm settle" returns. so we retry in case of OSError here.

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 4f82dfb)

@tchaikov tchaikov added this to the luminous milestone Oct 9, 2017

@tchaikov tchaikov requested review from and smithfarm Oct 9, 2017

@smithfarm smithfarm added the tools label Oct 9, 2017

@liewegas liewegas merged commit 91cb216 into ceph:luminous Oct 11, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-retry-oserror-luminous branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment