Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: by default, do not assert on leaks in the shared_cache code #18201

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@gregsfortytwo
Copy link
Member

commented Oct 9, 2017

Update the standard qa suite cluster configs so that we continue
asserting in our nightlies, but users don't hit this.

Signed-off-by: Greg Farnum gfarnum@redhat.com

@gregsfortytwo

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2017

I am actually a bit concerned about the teuthology config here. We have 166 yaml files that define roles, but I've only added the debug option to the tests using these six default clusters. :/

@gregsfortytwo gregsfortytwo force-pushed the gregsfortytwo:wip-21737-shutdown-assert branch from feb7763 to 1867c23 Oct 9, 2017

common: by default, do not assert on leaks in the shared_cache code
Update the standard qa suite cluster configs so that we continue
asserting in our nightlies, but users don't hit this.

Fixes: http://tracker.ceph.com/issues/21737

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
@liewegas

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Most of these settings live in teh ceph.conf.template in teuthology.git. That ceph.conf really should migrate into ceph.git someday, but assuming that eventually happens, I think this setting should just go there (with all the other debug = true settings).

@gregsfortytwo gregsfortytwo force-pushed the gregsfortytwo:wip-21737-shutdown-assert branch from 1867c23 to 165b61a Oct 9, 2017

@gregsfortytwo

This comment has been minimized.

Copy link
Member Author

commented Oct 9, 2017

Ah right. Removed those and added it to ceph.conf.template in ceph/teuthology#1118

@tchaikov tchaikov merged commit d2f290f into ceph:master Oct 11, 2017

4 of 5 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@gregsfortytwo gregsfortytwo deleted the gregsfortytwo:wip-21737-shutdown-assert branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.