Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PG: fix clang build vs private state events #18217

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

commented Oct 10, 2017

Signed-off-by: Sage Weil sage@redhat.com

osd/PG: fix clang build vs private state events
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-pg-clang branch from 5e71995 to 47a5fcc Oct 10, 2017

@wjwithagen wjwithagen self-requested a review Oct 10, 2017

@wjwithagen
Copy link
Contributor

left a comment

Compiles and builds fine on Clang/FreeBSD

@asomers

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2017

Builds for me too.

@tchaikov
Copy link
Contributor

left a comment

lgtm modulo the indents.

TrivialEvent(Initialize)
TrivialEvent(Load)
TrivialEvent(GotInfo)
TrivialEvent(NeedUpThru)
public:

This comment has been minimized.

Copy link
@tchaikov

tchaikov Oct 11, 2017

Contributor

indent.

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit d94730f into ceph:master Oct 13, 2017

4 of 5 checks passed

make check make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.