New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filestore: set default readahead and compaction threads for rocksdb #18234

Merged
merged 2 commits into from Oct 17, 2017

Conversation

Projects
None yet
4 participants
@jdurgin
Member

jdurgin commented Oct 11, 2017

markhpc and others added some commits Sep 21, 2017

common/options.cc: Set Filestore rocksdb compaction readahead option.
fixes: http://tracker.ceph.com/issues/21505

Signed-off-by: Mark Nelson <mnelson@redhat.com>
(cherry picked from commit 66567e5)
common/options: enable multiple rocksdb compaction threads for filestore
One of the major benefits of rocksdb over leveldb is multithreaded
compaction. The default of 1 thread does not provide much benefit, and
is insufficient for heavy rgw workloads.

For high-write and delete omap workloads I've seen up to 8 compaction
threads be used.  There's little overhead to having a higher max than
are needed, so set the default to 8.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit 023fa81)

Conflicts:
    src/common/options.cc (trivial)

@jdurgin jdurgin added this to the luminous milestone Oct 11, 2017

@jdurgin

This comment has been minimized.

Show comment
Hide comment
@jdurgin

jdurgin Oct 11, 2017

Member

from #18232 and #17900

Member

jdurgin commented Oct 11, 2017

from #18232 and #17900

@amitkumar50

LGTM

@liewegas liewegas merged commit 1718fd9 into ceph:luminous Oct 17, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@jdurgin jdurgin deleted the jdurgin:wip-filestore-rocksdb-luminous branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment