Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/mgr/prometheus: add osd_in/out metric; make osd_weight a metric #18243

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
2 participants
@jan--f
Copy link
Member

commented Oct 11, 2017

Signed-off-by: Jan Fajerski jfajerski@suse.com

@jcsp jcsp added cleanup mgr labels Oct 20, 2017

@jcsp
Copy link
Contributor

left a comment

One comment, and a rebase needed

status = osd[state]
self.metrics['osd_{}'.format(state)].set(
status,
(id_,))

This comment has been minimized.

Copy link
@jcsp

jcsp Oct 20, 2017

Contributor

This is setting the ceph_daemon label to just a number: it should be osd.0 or similar

This comment has been minimized.

Copy link
@jan--f

jan--f Oct 20, 2017

Author Member

ah good catch...fix pushed, rebase coming up

@jan--f jan--f force-pushed the jan--f:mgr-prom-osd-status branch from eb13ccf to de45cb6 Oct 20, 2017

jan--f added some commits Oct 11, 2017

pybind/mgr/prometheus: add osd_in/out metric; make osd_weight a metric
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
pybind/mgr/prometheus: no ports in osd_metadata
Ports might change on a OSD restart and this would create a new metadata
metric for this osd.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>

@jan--f jan--f force-pushed the jan--f:mgr-prom-osd-status branch from de45cb6 to 48fec7d Oct 20, 2017

@jcsp

jcsp approved these changes Nov 1, 2017

@jcsp jcsp merged commit 83b88f9 into ceph:master Nov 1, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.