Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd:show read:write proportion in the infomation of readwrite bench test #18249

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@PCzhangPC
Copy link

commented Oct 11, 2017

Signed-off-by: PCzhangPC pengcheng.zhang@easystack.cn

@PCzhangPC

This comment has been minimized.

Copy link
Author

commented Oct 11, 2017

@dillaman please help to review, thx

@PCzhangPC PCzhangPC force-pushed the PCzhangPC:addrwpro branch from f19f9e9 to 4f65d80 Oct 11, 2017

@PCzhangPC

This comment has been minimized.

Copy link
Author

commented Oct 16, 2017

@dillaman please have a look at this small clean-up , thx

@@ -212,6 +212,8 @@ int do_bench(librbd::Image& image, io_type_t io_type,
std::cout << "bench "
<< " type " << (io_type == IO_TYPE_READ ? "read" :
io_type == IO_TYPE_WRITE ? "write" : "readwrite")
<< (io_type == IO_TYPE_RW ? " read:write=" +
to_string(read_proportion) + ":" + to_string(100 - read_proportion) : "" )

This comment has been minimized.

Copy link
@dillaman

dillaman Oct 16, 2017

Contributor

Nit: extra space before closing parenthesis

This comment has been minimized.

Copy link
@PCzhangPC

PCzhangPC Oct 16, 2017

Author

updated already

PCzhangPC
rbd:show read:write proportion in the infomation of readwrite bench test
Signed-off-by: PCzhangPC <pengcheng.zhang@easystack.cn>

@PCzhangPC PCzhangPC force-pushed the PCzhangPC:addrwpro branch from 4f65d80 to c7a9b38 Oct 16, 2017

@dillaman
Copy link
Contributor

left a comment

lgtm

@dillaman dillaman added the needs-qa label Oct 16, 2017

@PCzhangPC

This comment has been minimized.

Copy link
Author

commented Oct 16, 2017

@ceph-jenkins retest this please

@dillaman dillaman merged commit be8e006 into ceph:master Oct 17, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.