Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: return EIO if object's size mismatch hinfo #18266

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@hjwsm1989
Copy link
Contributor

commented Oct 12, 2017

in ec overwrite mode

So it can read extra shards to get data but not
crash osd.

Fixes: http://tracker.ceph.com/issues/21769

Signed-off-by: huangjun huangjun@xsky.com

huangjun
osd: return EIO if object's size mismatch hinfo
in ec overwrite mode

So it can read extra shards to get data but not
crash osd.

Fixes: http://tracker.ceph.com/issues/21769

Signed-off-by: huangjun <huangjun@xsky.com>
@hjwsm1989

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

test please

@hjwsm1989

This comment has been minimized.

Copy link
Contributor Author

commented Oct 12, 2017

retest this please

@tchaikov tchaikov requested a review from jdurgin Oct 17, 2017

@hjwsm1989

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2017

@jdurgin @dzafman please review.

@dzafman dzafman self-requested a review Jul 12, 2018

@dzafman

This comment has been minimized.

Copy link
Member

commented Jul 12, 2018

@hjwsm1989 This needs a rebase. Have this been run through testing?

@hjwsm1989

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

@dzafman it didn't scheduled for QA

@dzafman

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

retest this please

@dzafman dzafman added the needs-qa label Aug 16, 2018

@dzafman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2018

@hjwsm1989 Please execute run-standalone.sh in your build tree:

cd build
../qa/run-standalone.sh 2>&1 | tee run.log

You should see "ALL ## TESTS PASSED" at the end.

@dzafman
Copy link
Member

left a comment

The commit comment is not correct. In allows_ecoverwrites mode, it will ignore shards that have hash_info missing. Later the size is only checked when NOT in allows_ecoverwrites.

@dzafman dzafman self-assigned this Sep 5, 2018

@dzafman

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

This pull request is going to conflict with #21611 which moves the get_hash_info() down lower. In the case where a shard is missing the change in #21611 will handle the error because it actually preserves any error coming from read. The missing shard would also fail the get_hash_info() which makes this more limited change work.

@hjwsm1989 If you have a reproducer for this, then test #21611 and see if it also works. If so, we can close this pull request.

@hjwsm1989

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@dzafman sorry for late reply, i think #21611 is a good way to resolve this, will close this now

@hjwsm1989 hjwsm1989 closed this Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.