Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix bilog entries on multipart complete #18271

Merged
merged 2 commits into from Oct 16, 2017

Conversation

Projects
None yet
4 participants
@cbodley
Copy link
Contributor

commented Oct 12, 2017

The rgw_bucket_complete_op() cls call for the RGWCompleteMultipart op includes a list of multipart parts to remove from the index in remove_objs. The removal of these bucket index entries are also logged to the bucket index log. However, they were using the same index version for all of these log entries, which meant that they all wrote to the same key. This overwrites the initial completion of the multipart object itself, so other zones would never try to sync it because they don't see it complete.

Fixes: http://tracker.ceph.com/issues/21772

test/rgw: add test_multipart_object_sync
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@joscollin

This comment has been minimized.

Copy link
Member

commented Oct 12, 2017

Sorry for adding testing labels. It was a bug in ptl-tool.py, which is in testing phase.

@cbodley cbodley changed the title test/rgw: add test_multipart_object_sync rgw: fix bilog entries on multipart complete Oct 12, 2017

@cbodley cbodley added bug fix and removed tests labels Oct 12, 2017

@cbodley cbodley requested a review from yehudasa Oct 12, 2017

@yehudasa
Copy link
Member

left a comment

lgtm, and yeah, we can probably disable logging of parts

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2017

@yuriw yuriw merged commit 44c89bd into ceph:master Oct 16, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-21772 branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.