New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: Ubuntu amd64 client can not discover the ubuntu arm64 ceph cluster #18293

Merged
merged 1 commit into from Nov 2, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Oct 13, 2017

arch/arm: set ceph_arch_aarch64_crc32 only if the build host supports…
… crc32cx

HWCAP_CRC32 is defined by the linux kernel source. so it's defined as
long as the linux kernel source is new enough. but the compiler on the
building host is not necessarily able to build the `crc32cx`
instruction. if we happen to have an incapable compiler on a machine with
recent linux kernel source, the dummy "ceph_crc32c_aarch64()" will be
selected by `ceph_choose_crc32()`. and it always return 0.

See-also: http://tracker.ceph.com/issues/19705
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 8a077bd)

@smithfarm smithfarm self-assigned this Oct 13, 2017

@smithfarm smithfarm added this to the luminous milestone Oct 13, 2017

@theanalyst theanalyst requested a review from liewegas Oct 27, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-6 and will be merged when approved

Member

theanalyst commented Oct 27, 2017

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-6 and will be merged when approved

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

jenkins test this please

Member

theanalyst commented Oct 27, 2017

jenkins test this please

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Nov 2, 2017

Member

@liewegas / @tchaikov is this good to go, passed the first round of rados qe

Member

theanalyst commented Nov 2, 2017

@liewegas / @tchaikov is this good to go, passed the first round of rados qe

@tchaikov tchaikov merged commit 96102df into ceph:luminous Nov 2, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-21795-luminous branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment