New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: encryption: reject requests that don't provide all expected headers #18429

Merged
merged 4 commits into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Oct 20, 2017

ZVampirEM77 added some commits Aug 25, 2017

rgw: encryption SSE-C add the details of error msg in response
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit 9502549)
rgw: encryption SSE-KMS add the details of error msg in response
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit 3f16785)
rgw: encryption fix the issue when not provide encryption mode
Now, in RGW, if someone want to upload an object using server-side
encryption with providing customer key or kms key id, but not
specify the encryption mode in the
"x-amz-server-side-encryption-customer-algorithm" or
"x-amz-server-side-encryption", the object will be uploaded
successfully without encryption.

This is not a correct way to deal with it. It is better to
return error.

Fixes: http://tracker.ceph.com/issues/21581

Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit f8c4be8)
rgw: encryption add exception handling for from_base64 on bad input
If calling from_base64 with charactors that is not base64 encoded,
rgw will crash.

Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
(cherry picked from commit f0b88e5)

@theanalyst theanalyst self-assigned this Oct 20, 2017

@theanalyst theanalyst added this to the luminous milestone Oct 20, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst
Member

theanalyst commented Oct 27, 2017

@theanalyst theanalyst requested review from cbodley and mattbenjamin Oct 27, 2017

@theanalyst theanalyst merged commit 68cc868 into ceph:luminous Oct 27, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment