New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: failed CompleteMultipartUpload request does not release lock #18430

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@theanalyst
Member

theanalyst commented Oct 20, 2017

rgw: release cls lock if taken in RGWCompleteMultipart
Follows Casey's proposal to conditionally release the lock in
::complete(), in order to avoid duplicated code in various early
return cases.

Fixes: http://tracker.ceph.com/issues/21596

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 704f793)

@theanalyst theanalyst self-assigned this Oct 20, 2017

@theanalyst theanalyst added this to the luminous milestone Oct 20, 2017

@theanalyst theanalyst requested review from mattbenjamin and cbodley Oct 27, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

Passed rgw suite at http://tracker.ceph.com/issues/21830#note-8 is this ok to merge?

Member

theanalyst commented Oct 27, 2017

Passed rgw suite at http://tracker.ceph.com/issues/21830#note-8 is this ok to merge?

@mattbenjamin

lgtm

@theanalyst theanalyst merged commit f2f8aef into ceph:luminous Oct 27, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment