New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: avoid logging keystone revocation failures when no keystone is configured #18441

Merged
merged 1 commit into from Oct 27, 2017

Conversation

Projects
None yet
2 participants
@theanalyst
Member

theanalyst commented Oct 20, 2017

rgw: defer constructing keystone engine unless url is configured
currently we create a keystone revocation thread even when keystone url
is empty, lets defer the construction of keystone unless the urls are
configured

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
(cherry picked from commit 104c2f5)

@theanalyst theanalyst self-assigned this Oct 20, 2017

@theanalyst theanalyst added this to the luminous milestone Oct 20, 2017

@theanalyst theanalyst requested review from cbodley and mattbenjamin Oct 27, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

Passed rgw suite at http://tracker.ceph.com/issues/21830#note-8 is this ok to merge?

Member

theanalyst commented Oct 27, 2017

Passed rgw suite at http://tracker.ceph.com/issues/21830#note-8 is this ok to merge?

@theanalyst theanalyst merged commit 0d9b3a0 into ceph:luminous Oct 27, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment