New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: buffer: fix ABI breakage by removing list _mempool member #18491

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Oct 23, 2017

No description provided.

liewegas added some commits Oct 19, 2017

buffer: allow mempool to be passed into raw* ctors and create methods
This is more convenient, and also faster than initializing it in
buffer_anon and the immediately moving it elsewhere.

Drop the optionality of the alignment argument.

No users yet.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 481277b)
buffer: remove list _mempool member
This broke the C++ ABI by changing the list structure size.  Also, it's
not necessary as we can infer the mempool by looking at the other list
contents.  We don't (currently) have a need to map an empty list to a
particular mempool and have that state stick.

Fixes: http://tracker.ceph.com/issues/21573
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 9b92d87)

@liewegas liewegas added the bug fix label Oct 23, 2017

@liewegas liewegas added this to the luminous milestone Oct 23, 2017

@yuriw

This comment has been minimized.

Show comment
Hide comment
Contributor

yuriw commented Oct 23, 2017

@yuriw yuriw requested a review from tchaikov Oct 24, 2017

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Oct 24, 2017

Contributor

the failures above are due to

  • centos 7.0 on vpm testnode does not offer new enough selinux-policy-base: we require selinux-policy-base >= 3.13.1-102.el7_3.16. but what it offers is 3.13.1-60.el7
  • TestLibRBD test fails
Contributor

tchaikov commented Oct 24, 2017

the failures above are due to

  • centos 7.0 on vpm testnode does not offer new enough selinux-policy-base: we require selinux-policy-base >= 3.13.1-102.el7_3.16. but what it offers is 3.13.1-60.el7
  • TestLibRBD test fails

@tchaikov tchaikov merged commit d52e59b into ceph:luminous Oct 24, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-21573-luminous branch Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment