New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: fix error handling in ListBucketIndexesCR #18591

Merged
merged 3 commits into from Nov 7, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Oct 27, 2017

cbodley added some commits Oct 9, 2017

rgw: ListBucketIndexesCR spawns entries_index after listing metadata
if the metadata listing fails, we won't have to clean up entries_index

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 7f127f5)
rgw: fix error handling in ListBucketIndexesCR
the call to set_state() returns 0, when we want operate() to return the
error code instead. use set_cr_error() to do this

Fixes: http://tracker.ceph.com/issues/21735

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit ed6340a)
rgw: RGWDataSyncControlCR retries on all errors
similar to RGWMetaSyncShardControlCR, we don't want to exit and
stop the data sync processor thread on failures. we want to keep
retrying with backoff

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 065e67b)

Conflicts:
	src/rgw/rgw_data_sync.cc (sync tracing)

@cbodley cbodley added this to the luminous milestone Oct 27, 2017

@theanalyst theanalyst requested a review from mattbenjamin Nov 7, 2017

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst
Member

theanalyst commented Nov 7, 2017

@theanalyst theanalyst merged commit ee27efa into ceph:luminous Nov 7, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-21938 branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment