New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mon/mgr: sync "mgr_command_descs","osd_metadata" and "mgr_metadata" prefixes to new mons #18620

Merged
merged 2 commits into from Nov 2, 2017

Conversation

Projects
None yet
5 participants
@tchaikov
Contributor

tchaikov commented Oct 30, 2017

mon/osd_metadata: sync osd_metadata table
sync osd_metadata table to new mons when add new mons

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
(cherry picked from commit 6c20433)
@smithfarm

cherry-pick looks good, backport is correctly staged

@renhwztetecs

This comment has been minimized.

Show comment
Hide comment
@renhwztetecs

renhwztetecs Oct 30, 2017

Member

In the virtual void get_store_prefixes() no const in the luminous branch, and the same Err of the #18621

Member

renhwztetecs commented Oct 30, 2017

In the virtual void get_store_prefixes() no const in the luminous branch, and the same Err of the #18621

mon/mgr: sync mgr_command_descs table and mgr_metadata table
sync mgr_command_descs table and mgr_metadata table to new mons

Fixes: http://tracker.ceph.com/issues/21527

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
(cherry picked from commit 13f6aa3)

Conflict: in master PaxosService::get_store_prefixes(..) is marked const
while in luminous, the cleanup commit which added the `const` is not
backported yet, so drop the `const` in the backported commit.
@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Oct 30, 2017

Contributor

@renhwztetecs fixed and repushed.

Contributor

tchaikov commented Oct 30, 2017

@renhwztetecs fixed and repushed.

@songbaisen

This comment has been minimized.

Show comment
Hide comment
@songbaisen

songbaisen Oct 30, 2017

@tchaikov Hi ! You close my pr. But the pr you said can fix the prolem, it is not useful. I have merge this pr code and rebuild ceph-mon and reboot all the mon.. but it contiue core dump. look like diffrent prolem. like below:

root@node-1151:/usr/bin# ceph-mon -i node-1151
2017-10-30 17:24:06.663421 7fbb2641cf00 -1 mon.node-1151@-1(probing).mgr e10829 Failed to load mgr commands: (2) No such file or directory
root@node-1151:/usr/bin#
root@node-1151:/usr/bin#
root@node-1151:/usr/bin# ceph osd perf
osd commit_latency(ms) apply_latency(ms)
2 0 0
1 2 2
0 0 0
root@node-1151:/usr/bin# ceph osd perf
^CCluster connection interrupted or timed out
root@node-1151:/usr/bin# ps -ef|grep ceph-mon
root 11991 11058 0 17:24 pts/0 00:00:00 grep --color=auto ceph-mon
root@node-1151:/usr/bin# ll /corefile/
total 10288
drwxrwxrwx 2 root root 4096 Oct 25 17:23 ./
drwxr-xr-x 24 root root 4096 Oct 24 14:30 ../
-rw------- 1 root root 318910464 Oct 25 17:23 core-ms_dispatch-29998-1508923395
root@node-1151:/usr/bin#

songbaisen commented Oct 30, 2017

@tchaikov Hi ! You close my pr. But the pr you said can fix the prolem, it is not useful. I have merge this pr code and rebuild ceph-mon and reboot all the mon.. but it contiue core dump. look like diffrent prolem. like below:

root@node-1151:/usr/bin# ceph-mon -i node-1151
2017-10-30 17:24:06.663421 7fbb2641cf00 -1 mon.node-1151@-1(probing).mgr e10829 Failed to load mgr commands: (2) No such file or directory
root@node-1151:/usr/bin#
root@node-1151:/usr/bin#
root@node-1151:/usr/bin# ceph osd perf
osd commit_latency(ms) apply_latency(ms)
2 0 0
1 2 2
0 0 0
root@node-1151:/usr/bin# ceph osd perf
^CCluster connection interrupted or timed out
root@node-1151:/usr/bin# ps -ef|grep ceph-mon
root 11991 11058 0 17:24 pts/0 00:00:00 grep --color=auto ceph-mon
root@node-1151:/usr/bin# ll /corefile/
total 10288
drwxrwxrwx 2 root root 4096 Oct 25 17:23 ./
drwxr-xr-x 24 root root 4096 Oct 24 14:30 ../
-rw------- 1 root root 318910464 Oct 25 17:23 core-ms_dispatch-29998-1508923395
root@node-1151:/usr/bin#

@songbaisen

This comment has been minimized.

Show comment
Hide comment
@songbaisen

songbaisen Oct 30, 2017

@renhwztetecs ping! have a look? 😄

songbaisen commented Oct 30, 2017

@renhwztetecs ping! have a look? 😄

@liewegas liewegas merged commit 4e1eec7 into ceph:luminous Nov 2, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Nov 2, 2017

Member

@jecluis does @songbaisen's crash above make sense to you?

Member

liewegas commented Nov 2, 2017

@jecluis does @songbaisen's crash above make sense to you?

@tchaikov tchaikov deleted the tchaikov:wip-21527-luminous branch Nov 3, 2017

@songbaisen

This comment has been minimized.

Show comment
Hide comment
@songbaisen

songbaisen Nov 3, 2017

@liewegas Yes sage, use the new master code, it will not core dump.

songbaisen commented Nov 3, 2017

@liewegas Yes sage, use the new master code, it will not core dump.

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Nov 3, 2017

Contributor

@songbaisen also, i am not able to reproduce the issue with latest luminous branch, following the steps you put in #18620 (comment)

Contributor

tchaikov commented Nov 3, 2017

@songbaisen also, i am not able to reproduce the issue with latest luminous branch, following the steps you put in #18620 (comment)

@renhwztetecs

This comment has been minimized.

Show comment
Hide comment
@renhwztetecs

renhwztetecs Nov 3, 2017

Member

@songbaisen
Maybe need backpoint this PR #17846 in your Ceph version

Member

renhwztetecs commented Nov 3, 2017

@songbaisen
Maybe need backpoint this PR #17846 in your Ceph version

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Nov 3, 2017

Member

already backported to luminous branch...

Member

liewegas commented Nov 3, 2017

already backported to luminous branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment