ceph-disk: activate/destroy/list --cluster option #18638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
requested review from
a user and
alfredodeza
and removed request for
a user
ghost
approved these changes
Oct 31, 2017
|
@dachary thanks for you quick review! |
tchaikov
force-pushed
the
wip-3253-ceph-disk-cluster
branch
from
7bb9c7d
to
beedca9
Compare
|
running ceph-disk test suite at http://pulpito.ceph.com/kchai-2017-10-31_07:55:29-ceph-disk-wip-17837-kefu-distro-basic-vps/ |
tchaikov
force-pushed
the
wip-3253-ceph-disk-cluster
branch
2 times, most recently
from
be32b02
to
11bf393
Compare
|
adding DNM, as ceph-disk test suite does not pass. |
tchaikov
force-pushed
the
wip-3253-ceph-disk-cluster
branch
from
11bf393
to
2d0ab4c
Compare
When the cluster name is specified prior to mounting the file system, it must be provided via the options because the FSID is not yet available. Signed-off-by: Loic Dachary <ldachary@redhat.com>
This option is required to get the proper mount options. The cluster will possibly be overriden after the partition is mounted, if the fsid is different from the provided option. Fixes: http://tracker.ceph.com/issues/3253 Signed-off-by: Loic Dachary <ldachary@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-3253-ceph-disk-cluster
branch
from
2d0ab4c
to
8af8b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.