New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: build_past_intervals_parallel: Ignore new partially created PGs #18673

Merged
merged 1 commit into from Nov 4, 2017

Conversation

Projects
None yet
5 participants
@dzafman
Member

dzafman commented Nov 1, 2017

In some situations PGs with DNE can be left behind especially with lots of crashes. These PGs don't need past_intervals rebuilt because there is nothing there. Skip those. This no longer applies in master branch.

@dzafman dzafman added this to the luminous milestone Nov 1, 2017

@dzafman dzafman requested a review from gregsfortytwo Nov 1, 2017

@gregsfortytwo

The commit should reference the tracker url?

Otherwise, this basically makes sense to me!

@dzafman

This comment has been minimized.

Show comment
Hide comment
@dzafman

This comment has been minimized.

Show comment
Hide comment
@dzafman

dzafman Nov 2, 2017

Member

@gregsfortytwo I did not create a test case for this particular issue. I mentioned this pull request in the tracker ticket http://tracker.ceph.com/issues/21833 so that it could be tested someone that is seeing it.

Member

dzafman commented Nov 2, 2017

@gregsfortytwo I did not create a test case for this particular issue. I mentioned this pull request in the tracker ticket http://tracker.ceph.com/issues/21833 so that it could be tested someone that is seeing it.

@yuriw

This comment has been minimized.

Show comment
Hide comment
@yuriw

yuriw Nov 4, 2017

Contributor

tests passed can be merged

Contributor

yuriw commented Nov 4, 2017

tests passed can be merged

@liewegas liewegas merged commit a5899a5 into ceph:luminous Nov 4, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment