New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: add option to fix up ruleset-* to crush-* for ec profiles #18945

Merged
merged 1 commit into from Nov 20, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Nov 15, 2017

The jewel->luminous upgrade test will fail if we finish the upgrade while
a workload setting old-style ec profiles is running. Add option to
automatically fix them up. Warn to the cluster log when this happens.

For now, enable this option to ease upgrades and whitelist the warning.

Only include this option in luminous so that we implicitly sunset this
compatibility kludge immediately.

Fixes: http://tracker.ceph.com/issues/22128
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added the bug fix label Nov 15, 2017

@liewegas liewegas added this to the luminous milestone Nov 15, 2017

@liewegas liewegas requested review from jecluis and jdurgin Nov 15, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Nov 15, 2017

Member

Is this an appropriate workaround?

Member

liewegas commented Nov 15, 2017

Is this an appropriate workaround?

@jecluis

This comment has been minimized.

Show comment
Hide comment
@jecluis

jecluis Nov 17, 2017

Member

@liewegas this seems like a decent transitional workaround. We should rip it at some point though. Maintaining this sort of exceptions can build up to a pain to maintain, but I don't see the harm in keeping it around until N is released, and make it obvious in the release notes that the band-aid is being ripped for N+1.

Member

jecluis commented Nov 17, 2017

@liewegas this seems like a decent transitional workaround. We should rip it at some point though. Maintaining this sort of exceptions can build up to a pain to maintain, but I don't see the harm in keeping it around until N is released, and make it obvious in the release notes that the band-aid is being ripped for N+1.

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Nov 17, 2017

Member

This pr targets L, actually, so it's not even in master. is that soon enough? :)

Member

liewegas commented Nov 17, 2017

This pr targets L, actually, so it's not even in master. is that soon enough? :)

@jecluis

This comment has been minimized.

Show comment
Hide comment
@jecluis

jecluis Nov 17, 2017

Member

lol duh - yeah ;)

Member

jecluis commented Nov 17, 2017

lol duh - yeah ;)

mon/OSDMonitor: add option to fix up ruleset-* to crush-* for ec prof…
…iles

The jewel->luminous upgrade test will fail if we finish the upgrade while
a workload setting old-style ec profiles is running.  Add option to
automatically fix them up.  Warn to the cluster log when this happens.

For now, enable this option to ease upgrades and whitelist the warning.

Only include this option in luminous so that we implicitly sunset this
compatibility kludge immediately.

Fixes: http://tracker.ceph.com/issues/22128
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 3532f23 into ceph:luminous Nov 20, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-22128 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment