Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: fix BoundedKeyCounter const_pointer_iterator #18953

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Copy link
Contributor

commented Nov 15, 2017

with libc++, clang fails to compile a call to:

  vector::assign(const_pointer_iterator, const_pointer_iterator)

because const_pointer_iterator does not satisfy the InputIterator concept. added the necessary typedefs for value_type and reference to reflect the pointer type

Fixes: http://tracker.ceph.com/issues/22139

common: fix BoundedKeyCounter const_pointer_iterator
with libc++, clang fails to compile a call to:

  vector::assign(const_pointer_iterator, const_pointer_iterator)

because const_pointer_iterator does not satisfy the InputIterator
concept. added the necessary typedefs for value_type and reference
to reflect the pointer type

Fixes: http://tracker.ceph.com/issues/22139

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley requested a review from wjwithagen Nov 15, 2017

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2017

tested with compiler explorer: https://godbolt.org/g/xKd35e

@wjwithagen
Copy link
Contributor

left a comment

@cbodley cbodley merged commit 2779185 into ceph:master Nov 15, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-22139 branch Nov 15, 2017

@wjwithagen

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2018

@cbodley
Hi Casey,

I'm trying to build the package v12.2.4 for FreeBSD, but it turns out that this is needed for backport.
How can I arrange that this is not missed if it ever comes to a 12.2.5 or higher?
I'm sure to forget it again.

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2018

@wjwithagen i updated http://tracker.ceph.com/issues/22139 to pending backport for luminous

@wjwithagen

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2018

@cbodley
Thanx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.