Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix rewrite options usage text #18968

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
2 participants
@joscollin
Copy link
Member

commented Nov 16, 2017

Fixed rewrite options usage text properly.
I thought I can fix it myself instead of giving many nits in #18918.

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin joscollin requested a review from cbodley Nov 16, 2017

@@ -434,17 +434,17 @@ Options

.. option:: --min-rewrite-size

Specify the min object size condition for bucket rewrite (default 4M).
min object size for bucket rewrite (default 4M).

This comment has been minimized.

Copy link
@cbodley

cbodley Nov 16, 2017

Contributor

looks like all the other option descriptions are capitalized. and a lot of them start with 'Specify', so maybe keep that part too? up to you

This comment has been minimized.

Copy link
@joscollin

joscollin Nov 17, 2017

Author Member

@cbodley Done. Please verify. Thanks.

rgw: fix rewrite options usage text
Fixed rewrite options usage text properly.

Signed-off-by: Jos Collin <jcollin@redhat.com>

@joscollin joscollin force-pushed the joscollin:wip-rgwadmin-rewrite branch from d273040 to eeec36b Nov 17, 2017

@cbodley cbodley merged commit 3bb3419 into ceph:master Nov 17, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@joscollin joscollin deleted the joscollin:wip-rgwadmin-rewrite branch Nov 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.