New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-disk create deprecation warnings #18989

Merged
merged 2 commits into from Nov 20, 2017

Conversation

Projects
None yet
5 participants
@alfredodeza
Contributor

alfredodeza commented Nov 17, 2017

alfredodeza added some commits Nov 17, 2017

ceph-disk add deprecation warnings in favor of ceph-volume
Signed-off-by: Alfredo Deza <adeza@redhat.com>

Fixes: http://tracker.ceph.com/issues/22154
(cherry picked from commit c9da92e)
doc/ceph-volume create a migration section to help users coming from …
…ceph-disk

Signed-off-by: Alfredo Deza <adeza@redhat.com>
(cherry picked from commit e433efe)
@alfredodeza

This comment has been minimized.

Show comment
Hide comment
@alfredodeza

alfredodeza Nov 17, 2017

Contributor

jenkins test docs

Contributor

alfredodeza commented Nov 17, 2017

jenkins test docs

@alfredodeza alfredodeza added this to the luminous milestone Nov 17, 2017

@alfredodeza alfredodeza requested review from tchaikov and andrewschoen Nov 17, 2017

warnings will show up that will link to this page. It is strongly suggested
that users start consuming ``ceph-volume``.
New deployments

This comment has been minimized.

@amitkumar50

amitkumar50 Nov 18, 2017

Contributor

NIT: New Deployments

@amitkumar50

amitkumar50 Nov 18, 2017

Contributor

NIT: New Deployments

@wjwithagen

This comment has been minimized.

Show comment
Hide comment
@wjwithagen

wjwithagen Nov 20, 2017

Contributor

@alfredodeza
Can you make it so that it is possible to suppress this humongous piece of text?
During debugging of all kinds of script I now get a free but useless warning about depreciation.
And unless somebody also writes ceph-volume zfs I would not like this tool to be deprecated.

Contributor

wjwithagen commented Nov 20, 2017

@alfredodeza
Can you make it so that it is possible to suppress this humongous piece of text?
During debugging of all kinds of script I now get a free but useless warning about depreciation.
And unless somebody also writes ceph-volume zfs I would not like this tool to be deprecated.

@alfredodeza

This comment has been minimized.

Show comment
Hide comment
@alfredodeza

alfredodeza Nov 20, 2017

Contributor

@wjwithagen these warnings are using Python's warning module which can be silenced via Python flags, functions, or an environment variable.

With python -W ignore for example, or with export PYTHONWARNINGS="ignore"

This is documented in further detail at

https://docs.python.org/2/using/cmdline.html?highlight=pythonwarnings#cmdoption-w

And

https://docs.python.org/2/using/cmdline.html?highlight=pythonwarnings#envvar-PYTHONWARNINGS

The ceph-disk tool is going to get deprecated within the next two major releases (or so), so there is time for someone to get a zfs implementation if they choose to.

Contributor

alfredodeza commented Nov 20, 2017

@wjwithagen these warnings are using Python's warning module which can be silenced via Python flags, functions, or an environment variable.

With python -W ignore for example, or with export PYTHONWARNINGS="ignore"

This is documented in further detail at

https://docs.python.org/2/using/cmdline.html?highlight=pythonwarnings#cmdoption-w

And

https://docs.python.org/2/using/cmdline.html?highlight=pythonwarnings#envvar-PYTHONWARNINGS

The ceph-disk tool is going to get deprecated within the next two major releases (or so), so there is time for someone to get a zfs implementation if they choose to.

@wjwithagen

This comment has been minimized.

Show comment
Hide comment
@wjwithagen

wjwithagen Nov 20, 2017

Contributor

@alfredodeza
You are correct that it is going to take another 2 releases to depricate ceph-disk.
But I would really appriciate a FeeBSD conditional for now, as not to distract any FreeBSD testers.
It might give them the idea to try later.

Contributor

wjwithagen commented Nov 20, 2017

@alfredodeza
You are correct that it is going to take another 2 releases to depricate ceph-disk.
But I would really appriciate a FeeBSD conditional for now, as not to distract any FreeBSD testers.
It might give them the idea to try later.

@andrewschoen andrewschoen merged commit 613634c into luminous Nov 20, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@andrewschoen andrewschoen deleted the wip-luminous-rm22154 branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment