Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: Fix S3 compatibility bug when CORS is not found #19104

Merged
merged 1 commit into from Feb 23, 2018

Conversation

@nickjanus
Copy link
Contributor

commented Nov 22, 2017

Currently, RGW will return the error message Not Found when CORS configuration has not been created for a bucket, but S3 returns NoSuchCORSConfiguration. This patch just changes the message. I'll link the accompanying PR for s3-tests.

rgw: Fix S3 compatibility bug when CORS is not found
Signed-off-by: Nick Janus <nickjanus@gmail.com>
@mattbenjamin

This comment has been minimized.

Copy link
Contributor

commented Nov 22, 2017

@nickjanus thanks for writing the test for this!

@mattbenjamin
Copy link
Contributor

left a comment

lgtm

@cbodley cbodley added the needs-qa label Dec 21, 2017

@yuriw yuriw changed the title rgw: Fix S3 compatibility bug when CORS is not found luminous: rgw: Fix S3 compatibility bug when CORS is not found Feb 14, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2018

@theanalyst theanalyst merged commit 1aeafcc into ceph:luminous Feb 23, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.