New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: ceph-disk flake8 test fails on very old, and very new, versions of flake8 #19152

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Nov 26, 2017

tests: ceph-disk: ignore E722 in flake8 test
Very old, and very new, versions of flake8 treat E722 as an error:

flake8 runtests: commands[0] | flake8 --ignore=H105,H405,E127 ceph_disk tests
ceph_disk/main.py:1575:9: E722 do not use bare except'
ceph_disk/main.py:1582:9: E722 do not use bare except'
ceph_disk/main.py:3252:5: E722 do not use bare except'
ceph_disk/main.py:3288:21: E722 do not use bare except'
ceph_disk/main.py:3296:17: E722 do not use bare except'
ceph_disk/main.py:4358:5: E722 do not use bare except'
tests/test_main.py:26:1: E722 do not use bare except'
ERROR: InvocationError: '/opt/j/ws/mkck/src/ceph-disk/.tox/flake8/bin/flake8 --ignore=H105,H405,E127 ceph_disk tests'

Fixes: http://tracker.ceph.com/issues/22207
References: https://gitlab.com/pycqa/flake8/issues/361

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 3600cd7)

@smithfarm smithfarm self-assigned this Nov 26, 2017

@smithfarm smithfarm added this to the luminous milestone Nov 26, 2017

@smithfarm smithfarm added bug fix core tools tests and removed core labels Nov 26, 2017

@smithfarm smithfarm merged commit acb0271 into ceph:luminous Nov 28, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-22235-luminous branch Nov 28, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Nov 28, 2017

Contributor

@amitkumar50 Sorry for omitting your review from the merge commit. It was unintentional. Next time I'll be more careful!

Contributor

smithfarm commented Nov 28, 2017

@amitkumar50 Sorry for omitting your review from the merge commit. It was unintentional. Next time I'll be more careful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment