New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: build/ops: macros expanding in spec file comment #19173

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Nov 27, 2017

rpm: rm macros in comments
rpm expands all macros in a .spec file, even those in comments. Drop the
percent signs so rpm will not expand these.

This change silences rpmlint's warning about macros in comments.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
(cherry picked from commit 5c1e9f5)

@smithfarm smithfarm self-assigned this Nov 27, 2017

@smithfarm smithfarm added this to the luminous milestone Nov 27, 2017

@smithfarm smithfarm changed the title from luminous: macros expanding in spec file comment to luminous: build/ops: macros expanding in spec file comment Nov 27, 2017

@smithfarm smithfarm requested review from b-ranto and ktdreyer Nov 27, 2017

@smithfarm smithfarm added build/ops and removed core labels Nov 27, 2017

@ddiss

ddiss approved these changes Nov 27, 2017

@smithfarm smithfarm merged commit 55f5d7d into ceph:luminous Nov 28, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-22251-luminous branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment