Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/rbd: add deep_copy method #19406

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@trociny
Copy link
Contributor

commented Dec 8, 2017

Signed-off-by: Mykola Golub to.my.trociny@gmail.com

@dillaman
Copy link
Contributor

left a comment

lgtm

self.image.create_snap('snap1')
self.image.write(b'b' * 256, 0)
dst_name = get_temp_image_name()
dst_features = features | RBD_FEATURE_STRIPINGV2

This comment has been minimized.

Copy link
@dillaman

dillaman Dec 11, 2017

Contributor

Nit: features might be None -- perhaps put a @require_new_format() guard?

This comment has been minimized.

Copy link
@trociny

trociny Dec 11, 2017

Author Contributor

Actually, it can't due to features = int(features) if features is not None else 61 in setup_module(). (does it mean we don't test python for old format?)

Anyway, I have removed this line and just pass features in the updated version (it looks like enough for testing API).

pybind/rbd: add deep_copy method
Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>

@trociny trociny force-pushed the trociny:wip-deep-copy-pybind branch from 5bb888f to 65b92c4 Dec 11, 2017

@dillaman dillaman merged commit a36f26d into ceph:master Dec 15, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@trociny trociny deleted the trociny:wip-deep-copy-pybind branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.