Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Fix PG status coloring #19431

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
3 participants
@wido
Copy link
Member

commented Dec 11, 2017

This was broken in the 12.2.2 release and PGs would not get a
color anymore.

This commit also makes sure pools/PGs are marked as red when
one or more PGs are inactive, inconsistent, incomplete, down, etc.

Signed-off-by: Wido den Hollander wido@42on.com

mgr/dashboard: Fix PG status coloring
This was broken in the 12.2.2 release and PGs would not get a
color anymore.

This commit also makes sure pools/PGs are marked as red when
one or more PGs are inactive, inconsistent, incomplete, down, etc.

Signed-off-by: Wido den Hollander <wido@42on.com>

@wido wido added the mgr label Dec 11, 2017

@wido wido requested a review from jcsp Dec 11, 2017

@liewegas liewegas added the bug fix label Dec 12, 2017

}
if (state != "active+clean"
&& state != "active+clean+scrubbing"

This comment has been minimized.

Copy link
@jcsp

jcsp Dec 14, 2017

Contributor

I think we shouldn't be indicating warnings for scrubbing states

This comment has been minimized.

Copy link
@wido

wido Dec 14, 2017

Author Member

I think you read the code wrongly. It excludes scrubbing from the state where a PG would be in warning state

This comment has been minimized.

Copy link
@jcsp

jcsp Dec 14, 2017

Contributor

Oops! My mistake. Making another coffee now.

@wido

This comment has been minimized.

Copy link
Member Author

commented Jan 8, 2018

@jcsp Would you mind taking a look after you finish your coffee? ;)

@jcsp

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2018

Wow, longest cup of coffee ever

@jcsp

jcsp approved these changes Jan 8, 2018

@jcsp jcsp merged commit 5ae196e into ceph:master Jan 8, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@jcsp

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2018

Backported here #19844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.