Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PG: include primary in PG operator<< for ec pools #19453

Merged
merged 1 commit into from Dec 13, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

commented Dec 12, 2017

Otherwise it is confusing!

Signed-off-by: Sage Weil sage@redhat.com

osd/PG: include primary in PG operator<< for ec pools
Otherwise it is confusing!

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov Dec 12, 2017

@@ -5591,6 +5591,8 @@ ostream& operator<<(ostream& out, const PG& pg)
<< " " << pg.up;
if (pg.acting != pg.up)
out << "/" << pg.acting;
if (pg.is_ec_pg())
out << "p" << pg.get_primary();

This comment has been minimized.

Copy link
@tchaikov

tchaikov Dec 13, 2017

Contributor

how about "p="?

This comment has been minimized.

Copy link
@liewegas

liewegas Dec 13, 2017

Author Member

just trying not to add more characters to the prefix than we need. p seemed more suggestive than @

@tchaikov tchaikov added the needs-qa label Dec 13, 2017

@liewegas liewegas merged commit 4a6ef42 into ceph:master Dec 13, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-pg-primary branch Dec 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.