Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common,mds,osd: Explicitly delete copy ctor if noncopyable #19465

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
3 participants
@shinobu-x
Copy link
Contributor

commented Dec 13, 2017

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@@ -1755,8 +1755,8 @@ class Objecter : public md_config_obs_t, public Dispatcher {
map_dne_bound(0) {}

// no copy!

This comment has been minimized.

Copy link
@tchaikov

tchaikov Dec 14, 2017

Contributor

might want to delete the comment of // no copy!, as the code is self-documenting.

@shinobu-x shinobu-x force-pushed the shinobu-x:no_copy_ctor_assignment branch from 8fab43c to 64801f9 Dec 14, 2017

@@ -127,9 +127,9 @@ class Capability : public Counter<Capability> {
mseq(0),
suppress(0), state(0) {
}
Capability(const Capability& other); // no copying
Capability(const Capability& other) = delete; // no copying

This comment has been minimized.

Copy link
@tchaikov

tchaikov Dec 14, 2017

Contributor

and these two.

This comment has been minimized.

Copy link
@shinobu-x

shinobu-x Dec 14, 2017

Author Contributor

good catch!

common/mds/osd: Explicitly delete if no copy, and remove incorrect co…
…mment

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

@shinobu-x shinobu-x force-pushed the shinobu-x:no_copy_ctor_assignment branch from 64801f9 to 4013607 Dec 14, 2017

@tchaikov tchaikov changed the title common/mds/osd: Explicitly delete if no copy, and remove incorrect comment common,mds,osd: Explicitly delete copy ctor if noncopyable Dec 15, 2017

@tchaikov tchaikov merged commit e962608 into ceph:master Dec 15, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.