Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/stanalone: pass options using --<option-name>=<value> #19544

Merged

Conversation

Projects
None yet
4 participants
@tchaikov
Copy link
Contributor

commented Dec 15, 2017

not --<option-name> <value>, otherwise ceph-authtool would error
out:

$ CEPH_ARGS='--osd-map-max-advance 1000' bin/ceph-authtool --gen-print-key
bin/ceph-authtool: unexpected '1000'
usage: ceph-authtool keyringfile [OPTIONS]...
....

but using the syntax of --<option-name>=<value>, it works:

$ CEPH_ARGS='--osd-map-max-advance=1000' bin/ceph-authtool --gen-print-key
AQBAhTNamf5+ABAASkAp/6IGq7LkUTEOMp/fgw==

Signed-off-by: Kefu Chai kchai@redhat.com

qa/stanalone: pass options using --<option-name>=<value>
not "--<option-name> <value>', otherwise `ceph-authtool` would error
out:

$ CEPH_ARGS='--osd-map-max-advance 1000' bin/ceph-authtool --gen-print-key
bin/ceph-authtool: unexpected '1000'
usage: ceph-authtool keyringfile [OPTIONS]...
....

but using the syntax of `--<option-name>=<value>', it works:

$ CEPH_ARGS='--osd-map-max-advance=1000' bin/ceph-authtool --gen-print-key
AQBAhTNamf5+ABAASkAp/6IGq7LkUTEOMp/fgw==

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2017

this PR should address http://pulpito.ceph.com/kchai-2017-12-15_07:36:59-rados-wip-kefu-testing-2017-12-14-1157-distro-basic-mira/1967885/

2017-12-15T07:51:45.623 INFO:tasks.workunit.client.0.mira080.stderr:command: Running command: /usr/bin/ceph-authtool --gen-print-key
2017-12-15T07:51:45.658 INFO:tasks.workunit.client.0.mira080.stderr:__init__: stderr 2017-12-15 07:51:45.646 7fd259165480 -1 WARNING: all dangerous and experimental features are ena
bled.
2017-12-15T07:51:45.658 INFO:tasks.workunit.client.0.mira080.stderr:2017-12-15 07:51:45.646 7fd259165480 -1 WARNING: all dangerous and experimental features are enabled.
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:/usr/bin/ceph-authtool: unexpected '1000'
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:Traceback (most recent call last):
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/sbin/ceph-disk", line 9, in <module>
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:    load_entry_point('ceph-disk==1.0.0', 'console_scripts', 'ceph-disk')()
2017-12-15T07:51:45.659 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 5747, in run
2017-12-15T07:51:45.661 INFO:tasks.workunit.client.0.mira080.stderr:    main(sys.argv[1:])
2017-12-15T07:51:45.661 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 5685, in main
2017-12-15T07:51:45.661 INFO:tasks.workunit.client.0.mira080.stderr:    args.func(args)
2017-12-15T07:51:45.661 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 3794, in main_activate
2017-12-15T07:51:45.662 INFO:tasks.workunit.client.0.mira080.stderr:    init=args.mark_init,
2017-12-15T07:51:45.663 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 3606, in activate_dir
2017-12-15T07:51:45.664 INFO:tasks.workunit.client.0.mira080.stderr:    (osd_id, cluster) = activate(path, activate_key_template, init)
2017-12-15T07:51:45.665 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 3699, in activate
2017-12-15T07:51:45.665 INFO:tasks.workunit.client.0.mira080.stderr:    path=path,
2017-12-15T07:51:45.665 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 1104, in allocate_osd_id
2017-12-15T07:51:45.665 INFO:tasks.workunit.client.0.mira080.stderr:    secrets = Secrets()
2017-12-15T07:51:45.666 INFO:tasks.workunit.client.0.mira080.stderr:  File "/usr/lib/python2.7/dist-packages/ceph_disk/main.py", line 2652, in __init__
2017-12-15T07:51:45.666 INFO:tasks.workunit.client.0.mira080.stderr:    assert ret == 0
2017-12-15T07:51:45.666 INFO:tasks.workunit.client.0.mira080.stderr:AssertionError
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2017

@liewegas liewegas merged commit 6446303 into ceph:mimic-dev1 Dec 20, 2017

3 of 4 checks passed

make check make check failed
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.