Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: proper error message when tier_type does not exist #19575

Merged
merged 1 commit into from Jan 8, 2018

Conversation

Projects
None yet
5 participants
@liuchang0812
Copy link
Contributor

commented Dec 18, 2017

at now, creating a zone does not check whether the sync module exists. we
should make sure that tier_type is valid.

Fixes: http://tracker.ceph.com/issues/22469

Signed-off-by: Chang Liu liuchang0812@gmail.com
Signed-off-by: lvshanchun lvshanchun@gmail.com

@liuchang0812

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2017

➜  build git:(rgw-tier-type-check) ✗ ./bin/radosgw-admin zone create --rgw-zonegroup=s3-export --rgw-zone=zone6 --endpoints=localhost:8005 --access-key=access --secret=secret --tier-type=awsasdf --tier-config=s3_endpoint=http://localhost:8006,access_key=0555b35654ad1656d804,secret=h7GhxuBLTrlhVUyxSPUKUV8r/2EI4ngqJxD7iBdBYLhwluN30JaT3Q==
2017-12-18 17:33:33.453 7fe6537922c0 -1 WARNING: all dangerous and experimental features are enabled.
2017-12-18 17:33:33.453 7fe6537922c0 -1 WARNING: all dangerous and experimental features are enabled.
2017-12-18 17:33:33.453 7fe6537922c0 -1 WARNING: all dangerous and experimental features are enabled.
2017-12-18 17:33:33.634 7fe6537922c0  0 ERROR: could not found sync module: awsasdf
failed to add zone zone6 to zonegroup s3-export: (2) No such file or directory

@tchaikov tchaikov added the rgw label Dec 19, 2017

@liuchang0812

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

jenkins test this please

@yehudasa @cbodley mind taking a look?

ss << i << " ";
}

lderr(cct) << "ERROR: " << zone_public_config.tier_type << " sync module does not exist. valied sync modules: " << ss.str() << dendl;

This comment has been minimized.

Copy link
@amitkumar50

amitkumar50 Dec 19, 2017

Contributor

valied incorrect spelling

This comment has been minimized.

Copy link
@liuchang0812

liuchang0812 Dec 19, 2017

Author Contributor

oooops, fixed it, thanks!

rgw: proper error message when tier_type does not exist
at now, creating a zone does not check whether the sync module exists. we
should make sure that tier_type is valid.

Fixes: http://tracker.ceph.com/issues/22469

Signed-off-by: Chang Liu <liuchang0812@gmail.com>
Signed-off-by: lvshanchun <lvshanchun@gmail.com>

@liuchang0812 liuchang0812 force-pushed the liuchang0812:rgw-tier-type-check branch from 3117036 to 35cc879 Dec 19, 2017

@liuchang0812

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

2017-12-19 21:06:41.909 7f45230cd2c0  0 ERROR: could not found sync module: awsasdf,  valid sync modules: [elasticsearch,log,rgw]

@cbodley cbodley requested a review from yehudasa Dec 19, 2017

@yehudasa
Copy link
Member

left a comment

lgtm

@yehudasa yehudasa added the needs-qa label Jan 2, 2018

@yehudasa

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

this one could benefit from a teuthology test

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2018

@yuriw yuriw merged commit 8096752 into ceph:master Jan 8, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liuchang0812 liuchang0812 deleted the liuchang0812:rgw-tier-type-check branch Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.