Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: optimize next start time for lifecycle #19596

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
5 participants
@qrGitHub
Copy link

commented Dec 19, 2017

If the scheduling time of lifecycle is after the current time, the processing of lifecycle should not be postponed for a day.

Bingyin Zhang
rgw: optimize next start time for lifecycle
* If the scheduling time of lifecycle is after the current time, the
* processing of lifecycle should not be postponed for a day

Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>
@qrGitHub

This comment has been minimized.

Copy link
Author

commented Dec 19, 2017

Hi @cbodley, would you help to review this? Thanks.

@cbodley cbodley requested a review from dang Dec 19, 2017

@cbodley cbodley added the rgw label Dec 19, 2017

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Dec 21, 2017

Hi @dang, would you help to review this? Thanks.

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Dec 23, 2017

Hi @cbodley @adamemerson, @dang, is anybody help to review this? Thanks.

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Dec 25, 2017

Hi @cbodley @joscollin, is anybody else help to review this? Thanks.

@adamemerson

This comment has been minimized.

Copy link
Contributor

commented Dec 25, 2017

Ask again after January 2nd. Red Hat in Europe and North America is on company shutdown.

@joscollin

This comment has been minimized.

Copy link
Member

commented Dec 26, 2017

jenkins test docs

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Jan 8, 2018

Hi @cbodley, is anybody else help to review this? Thanks.

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2018

ping @dang

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Jan 8, 2018

Hi @dang, would you help to review this? Thanks.

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Jan 15, 2018

Hi @cbodley, how to ping @dang?

@dang

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2018

I'm not sure I agree, if I'm understanding it properly. We shouldn't start before the next scheduled time, which should be the next day.

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Jan 19, 2018

Hi @dang, when rgw_lifecycle_work_time is "12:00-18:00" and lifecycle is started at "2018 0119 0800", the old code will schedule lifecycle on "2018 0120 1200", but what about "2018 0119 1200"?

@dang

dang approved these changes Jan 19, 2018

Copy link
Contributor

left a comment

Okay, I understand now, and it's technically correct, although I don't think it matters. Lifecycle only operates on the scale of days, so one day off on only the first day can't matter much. Still, it's fine.

@cbodley cbodley added the needs-qa label Jan 19, 2018

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

thanks @dang!

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Jan 25, 2018

Hi @cbodley, can this be merged? Thanks.

@cbodley cbodley merged commit c42f763 into ceph:master Jan 25, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.