Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: change ObjectCache::lru from deque back to list #19768

Merged
merged 2 commits into from Jan 3, 2018

Conversation

Projects
None yet
2 participants
@cbodley
Copy link
Contributor

commented Jan 3, 2018

ObjectCacheEntry stores an lru_iter into this lru, and depends on that iterator remaining valid as other entries are inserted/erased

Fixes: http://tracker.ceph.com/issues/22560

rgw: change ObjectCache::lru from deque back to list
ObjectCacheEntry stores an lru_iter into this lru, and depends on that
iterator remaining valid as other entries are inserted/erased

Fixes: http://tracker.ceph.com/issues/22560

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley requested a review from adamemerson Jan 3, 2018

rgw: add invalidate_lru() call back to ObjectCache::put()
the removal of this line was causing s3test failures independently of
the change from list-deque

Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley referenced this pull request Jan 3, 2018

Merged

Cache on the barrelhead #19581

@mattbenjamin
Copy link
Contributor

left a comment

lgtm--let's unbreak master

@mattbenjamin mattbenjamin merged commit 6b72f45 into ceph:master Jan 3, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-rgw-cache-dedeque branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.