jewel: rgw: fix marker encoding problem. #20123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For object names that contain / and %, it is possible in some circumstances (at least with boto) for "listobjects" operations to attempt to fetch additional objects using 'marker=' and a value containing both / and %. When this happens, when using AWSv4, radosgw returns a signature validation error. It's possible to artifically do this in boto on any bucket (regardless of content) with sometihng like s=bucket.get_all_keys(marker='level1/8e%25%25FAH3') this fails because "recoder" assumes the query string was already encoded if any value is encoded, and fails to take into account that the string might be partially encoded, as in this case. The fix here is to always decode the value, then always encode. Fixes: http://tracker.ceph.com/issues/20463 Signed-off-by: Marcus Watts <mwatts@redhat.com> (cherry picked from commit f1ed745) Signed-off-by: Orit Wasserman <owasserm@redhat.com> Conflicts: src/rgw/rgw_auth_s3.cc (cherry picked from commit 34cf013)
mattbenjamin
changed the title
mattbenjamin
changed the title
|
@smithfarm it's not--I have no idea how the older PR went unmerged since sept 14--we need to merge one of these asap |
|
Closing as duplicate of #17731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For object names that contain / and %, it is possible in
some circumstances (at least with boto) for "listobjects"
operations to attempt to fetch additional objects using
'marker=' and a value containing both / and %. When this
happens, when using AWSv4, radosgw returns a signature
validation error. It's possible to artifically do this
in boto on any bucket (regardless of content) with
sometihng like s=bucket.get_all_keys(marker='level1/8e%25%25FAH3')
this fails because "recoder" assumes the query string
was already encoded if any value is encoded, and fails
to take into account that the string might be partially
encoded, as in this case.
The fix here is to always decode the value, then always encode.
Fixes: http://tracker.ceph.com/issues/20463
Signed-off-by: Marcus Watts mwatts@redhat.com
(cherry picked from commit f1ed745)
Signed-off-by: Orit Wasserman owasserm@redhat.com
Conflicts:
src/rgw/rgw_auth_s3.cc
(cherry picked from commit 34cf013)