Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: 'make check' builds radosgw and its cls dependencies #20422

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
3 participants
@cbodley
Copy link
Contributor

commented Feb 13, 2018

'make check' does not otherwise catch compilation failures in radosgw (rgw_main.cc) or the cls libraries that it depends on

cmake: 'make check' builds radosgw and its cls dependencies
Signed-off-by: Casey Bodley <cbodley@redhat.com>

@cbodley cbodley requested review from tchaikov and alimaredia Feb 13, 2018

@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

see #20396 (comment) for motivation

@tchaikov tchaikov added needs-qa and removed needs-qa labels Feb 13, 2018

@tchaikov tchaikov merged commit 9a0d151 into ceph:master Feb 13, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
@cbodley

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2018

thanks!

@cbodley cbodley deleted the cbodley:wip-check-cls-rgw branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.