Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-deps.sh: set python2 %bcond by environment #20436

Merged
merged 1 commit into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

commented Feb 14, 2018

If there is no /usr/bin/python2 we need to set %bcond_with python2.

Fixes: http://tracker.ceph.com/issues/22999
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm added the build/ops label Feb 14, 2018

@smithfarm smithfarm requested review from tchaikov, jan--f, ktdreyer, b-ranto and rjfd Feb 14, 2018

@jan--f

jan--f approved these changes Feb 17, 2018

Copy link
Member

left a comment

lgtm

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2018

nit, would be better if we can drop the build/ops prefix in the commit message, install-deps.sh is good enough, IMHO. if we go further in this way, the commit messages of changes of OSD will start with "core/osd". that would be redundant.

install-deps.sh: set python2 %bcond by environment
If there is no /usr/bin/python2 we need to set %bcond_with python2.

Fixes: http://tracker.ceph.com/issues/22999
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm force-pushed the smithfarm:wip-22999 branch from 7f5c42c to fe028f8 Feb 27, 2018

@smithfarm smithfarm changed the title build/ops: install-deps.sh: set python2 %bcond by environment install-deps.sh: set python2 %bcond by environment Feb 27, 2018

@smithfarm smithfarm merged commit 6a2bcea into ceph:master Feb 27, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-22999 branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.