Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: don't overwrite the error code from the remove action #20481

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

commented Feb 19, 2018

Signed-off-by: Jason Dillaman dillaman@redhat.com

@trociny
Copy link
Contributor

left a comment

LGTM

There is a potential overwrite in r == -EMLINK case too, when it creates a rados context to get the pool name. Probably worth to fix too.

rbd: don't overwrite the error code from the remove action
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-rbd-remove-error branch from 1f7dd87 to 11c1a07 Feb 19, 2018

@trociny trociny merged commit 6f6d210 into ceph:master Feb 20, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-rbd-remove-error branch Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.