Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume correctly normalize mount flags #20543

Merged
merged 2 commits into from Feb 23, 2018

Conversation

Projects
None yet
4 participants
@alfredodeza
Copy link
Contributor

commented Feb 22, 2018

@alfredodeza alfredodeza requested a review from andrewschoen Feb 22, 2018

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2018

jenkins test ceph-volume tox

@batrick batrick added the ceph-volume label Feb 22, 2018

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

jenkins test ceph-volume lvm all

@alfredodeza alfredodeza force-pushed the wip-rm23080 branch from 09b1316 to 6671cb4 Feb 22, 2018

alfredodeza added some commits Feb 22, 2018

ceph-volume util.prepare normalize mount flags for CLI
Signed-off-by: Alfredo Deza <adeza@redhat.com>
ceph-volume tests.util update tests for mount flags
Include parametrized flags for ensuring a combination of values will
still be normalized regardless on how they are on ceph.conf

Signed-off-by: Alfredo Deza <adeza@redhat.com>
@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2018

@smithfarm @theanalyst @yuriw once this gets merged (after all functional tests pass) we will start the backport to Luminous for 12.2.4

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

jenkins test ceph-volume lvm all

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

jenkins test ceph-volume lvm xenial-filestore-create

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2018

jenkins test ceph-volume lvm xenial-bluestore-create

@alfredodeza alfredodeza merged commit f584df7 into master Feb 23, 2018

13 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume lvm testing centos7-bluestore-create ceph-volume lvm centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt ceph-volume lvm centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create ceph-volume lvm centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt ceph-volume lvm centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create ceph-volume lvm xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt ceph-volume lvm xenial-filestore-dmcrypt OK
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@alfredodeza alfredodeza deleted the wip-rm23080 branch Feb 23, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2018

@alfredodeza Cool. Ping us in the backport then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.