Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[DNM] jewel: rgw: fix memory fragmentation problem reading data from client. #20698
STREAM_IO(s)->read() can, and nearly always returns "short" reads.
mg_read() returns 0 upon EOF. The next read to mg_read()
Signed-off-by: Marcus Watts firstname.lastname@example.org
I've pushed an update to this PR. I moved the read-fill loop down into the civetweb code. This has the same effect as the previous code for PUT, but it extends the same fill logic for every other call to STREAM_IO(s)->read. I do not think any callers of this were expecting short reads, and I believe this may explain reports from the field about hard to reproduce signature failures.
changed the title
rgw: fix memory fragmentation problem reading data from client.
Mar 5, 2018
smithfarm left a comment
The commit message lacks a "Conflicts" section, giving rise to a false notion that the commit cherry-picked to jewel cleanly.
Please add that section. Just append to the commit message:
(Ideally, after the filename there would follow a description of the conflicts and how they were resolved.)