Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/async: size of EventCenter::file_events should be greater than fd #20764

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@chenyupeng360
Copy link
Contributor

commented Mar 7, 2018

When trying to generate a file event from an FD greater than or equal to the size of file_events vector,
make sure that the resized vector can hold the FD safely.

Fixes: http://tracker.ceph.com/issues/23253

Signed-off-by: Yupeng Chen chenyupeng-it@360.cn

@tchaikov tchaikov changed the title Restrict boundary when resizing event_files in EventCenter. msg/async: size of EventCenter::file_events should be greater than fd Mar 7, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2018

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it would be "msg/async: "

msg/async: size of EventCenter::file_events should be greater than fd.
When trying to generate a file event from an FD greater than or equal to the size of file_events vector,
make sure that the resized vector can hold the FD safely.

Fixes: http://tracker.ceph.com/issues/23253

Signed-off-by: Yupeng Chen <chenyupeng-it@360.cn>

@chenyupeng360 chenyupeng360 force-pushed the chenyupeng360:master branch from 6baf5f0 to 39023b5 Mar 7, 2018

@chenyupeng360

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2018

@tchaikov OK, I've updated the commit log.

@tchaikov tchaikov added the bug fix label Mar 7, 2018

@tchaikov tchaikov requested a review from yuyuyu101 Mar 7, 2018

@tchaikov tchaikov added the needs-qa label Mar 7, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2018

retest this please

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2018

http://pulpito.ceph.com/kchai-2018-03-08_12:59:37-rados-wip-kefu-testing-2018-03-08-1932-distro-basic-smithi/

  • the swift failure was caused by #20419
  • and i reran osd-pool-create.sh multiple times locally, and was not able to reproduce that failure.

@tchaikov tchaikov merged commit d6dbf9c into ceph:master Mar 8, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.