Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[DNM] mgr/dashboard: Add RBD create functionality (frontend) #20852
Conversation
ricardoasmarques
requested review from
tspmelo
and
Devp00l
Mar 12, 2018
ricardoasmarques
added
DNM
dashboard
labels
Mar 12, 2018
This comment has been minimized.
This comment has been minimized.
|
Could you please take a look at the "make check" test failure in Jenkins? |
ricardoasmarques
force-pushed the
ricardoasmarques:wip-rbd-management
branch
from
20ef196
to
19c8d91
Mar 13, 2018
This comment has been minimized.
This comment has been minimized.
|
jenkins retest this please |
This comment has been minimized.
This comment has been minimized.
|
FYI, #20751 is merged now. |
ricardoasmarques
force-pushed the
ricardoasmarques:wip-rbd-management
branch
from
19c8d91
to
dafda18
Mar 14, 2018
ricardoasmarques
changed the title
[DNM] mgr/dashboard: Add RBD create functionality (frontend)
mgr/dashboard: Add RBD create functionality (frontend)
Mar 14, 2018
ricardoasmarques
removed
the
DNM
label
Mar 14, 2018
This comment has been minimized.
This comment has been minimized.
|
This PR is now rebased, and ready for review. |
ricardoasmarques
added
the
DNM
label
Mar 16, 2018
ricardoasmarques
changed the title
mgr/dashboard: Add RBD create functionality (frontend)
[DNM] mgr/dashboard: Add RBD create functionality (frontend)
Mar 16, 2018
ricardoasmarques
added some commits
Feb 21, 2018
ricardoasmarques
force-pushed the
ricardoasmarques:wip-rbd-management
branch
from
dafda18
to
a9844dc
Mar 16, 2018
This comment has been minimized.
This comment has been minimized.
|
I'm closing this PR because I will create a new PR with a single page to manage all RBDs (from all Pools). |
ricardoasmarques
closed this
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ricardoasmarques commentedMar 12, 2018
•
edited
This PR should be merged after we have a "Block > RBDs" menu entry, that lists all RBD images.
This PR is the frontend part of RBD create functionality.
This PR also adds a detail view of the selected RBD:
And also adds some shared components that can be reused by other forms: