New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] mgr/dashboard: Add RBD create functionality (frontend) #20852

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ricardoasmarques
Copy link
Member

ricardoasmarques commented Mar 12, 2018

This PR should be merged after we have a "Block > RBDs" menu entry, that lists all RBD images.


This PR is the frontend part of RBD create functionality.

screenshot from 2018-03-12 16-30-28

This PR also adds a detail view of the selected RBD:

screenshot from 2018-03-12 16-40-47

And also adds some shared components that can be reused by other forms:

  • DimlessBinaryDirective
  • Helper component
@LenzGr

This comment has been minimized.

Copy link
Contributor

LenzGr commented Mar 12, 2018

Could you please take a look at the "make check" test failure in Jenkins?

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-rbd-management branch from 20ef196 to 19c8d91 Mar 13, 2018

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

ricardoasmarques commented Mar 13, 2018

jenkins retest this please

@LenzGr

This comment has been minimized.

Copy link
Contributor

LenzGr commented Mar 14, 2018

FYI, #20751 is merged now.

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-rbd-management branch from 19c8d91 to dafda18 Mar 14, 2018

@ricardoasmarques ricardoasmarques changed the title [DNM] mgr/dashboard: Add RBD create functionality (frontend) mgr/dashboard: Add RBD create functionality (frontend) Mar 14, 2018

@ricardoasmarques ricardoasmarques removed the DNM label Mar 14, 2018

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

ricardoasmarques commented Mar 14, 2018

This PR is now rebased, and ready for review.

@ricardoasmarques ricardoasmarques changed the title mgr/dashboard: Add RBD create functionality (frontend) [DNM] mgr/dashboard: Add RBD create functionality (frontend) Mar 16, 2018

ricardoasmarques added some commits Feb 21, 2018

mgr/dashboard: Add RBD details page
Signed-off-by: Ricardo Marques <rimarques@suse.com>
mgr/dashboard: Add DimlessBinaryDirective
Signed-off-by: Ricardo Marques <rimarques@suse.com>
mgr/dashboard: Add helper component
Signed-off-by: Ricardo Marques <rimarques@suse.com>
mgr/dashboard: Fix datatable actions selector
Signed-off-by: Ricardo Marques <rimarques@suse.com>
mgr/dashboard: Add RBD create functionality (frontend)
Signed-off-by: Ricardo Marques <rimarques@suse.com>

@ricardoasmarques ricardoasmarques force-pushed the ricardoasmarques:wip-rbd-management branch from dafda18 to a9844dc Mar 16, 2018

@ricardoasmarques

This comment has been minimized.

Copy link
Member Author

ricardoasmarques commented Mar 23, 2018

I'm closing this PR because I will create a new PR with a single page to manage all RBDs (from all Pools).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment